Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preload banner to sample app #48

Closed
wants to merge 1 commit into from
Closed

Add preload banner to sample app #48

wants to merge 1 commit into from

Conversation

markmur
Copy link
Contributor

@markmur markmur commented Nov 6, 2023

What are you trying to accomplish?

  • Exposes Checkout SDK event listeners
  • Displays a "Preloaded checkout in x s" banner when checkout finished loading

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@markmur markmur self-assigned this Nov 6, 2023
@markmur markmur requested a review from a team as a code owner November 6, 2023 09:08
@markmur markmur force-pushed the markmur/preload-banner branch 2 times, most recently from 33e248f to aecb945 Compare November 6, 2023 09:26
@markmur markmur force-pushed the markmur/preload-banner branch 5 times, most recently from 159e27c to 32b51ea Compare November 7, 2023 11:52
@markmur markmur force-pushed the markmur/preload-banner branch from 32b51ea to 5a8af8b Compare November 7, 2023 11:56
@markmur markmur requested review from cianbuckley and kiftio November 7, 2023 12:20
@markmur
Copy link
Contributor Author

markmur commented Dec 4, 2023 •
edited
Loading

Closing in favour of #56

@markmur markmur closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrooriente leandrooriente leandrooriente left review comments

@cianbuckley cianbuckley Awaiting requested review from cianbuckley

@kiftio kiftio Awaiting requested review from kiftio

Assignees

@markmur markmur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmur @leandrooriente